Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default ARKODE methods #547

Open
wants to merge 41 commits into
base: develop
Choose a base branch
from
Open

Update default ARKODE methods #547

wants to merge 41 commits into from
+4,745 −3,722

Conversation

Steven-Roberts
Copy link
Collaborator

@Steven-Roberts Steven-Roberts commented Jul 26, 2024 •
edited
Loading

Replaces #345

In draft status until we settle on the defaults. Then I'll update the docs and output files.

Justification:

  • ARK order >2: Follows the recommendations in the conclusion of https://doi.org/10.1016/j.apnum.2018.10.007
  • ERK order 4: Improved principal error and embedded quality metrics
  • ERK order 5: Improved principal error and embedded quality metrics
  • ERK order 8: Switch to a method designed for local extrapolation mode. Likely better principal error but need to confirm
  • IRK order 2: Improved principal error, L-stability, and stage order 2
  • IRK order >2: Follows the recommendations in the conclusion of https://doi.org/10.1016/j.apnum.2019.07.008

@drreynolds drreynolds mentioned this pull request Sep 5, 2024
Open
drreynolds added a commit that referenced this pull request Sep 6, 2024
@drreynolds
Removed changesets from PR #547
6f59400
@Steven-Roberts Steven-Roberts marked this pull request as ready for review September 8, 2024 06:31
drreynolds
drreynolds reviewed Sep 10, 2024
View reviewed changes
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
gardner48
gardner48 requested changes Sep 11, 2024
View reviewed changes
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Constants.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Outdated Show resolved Hide resolved
doc/arkode/guide/source/Butcher.rst Show resolved Hide resolved
Steven-Roberts and others added 2 commits September 10, 2024 20:20
@Steven-Roberts @gardner48
Apply suggestions from code review
d61fb37 
Co-authored-by: David Gardner <gardner48@llnl.gov>
@Steven-Roberts
Remove trailing 0 from table
405355c
@balos1 balos1 added this to the SUNDIALS Next milestone Sep 12, 2024
@Steven-Roberts
Copy link
Collaborator Author

@gardner48 @drreynolds can you confirm this is the table format you're looking for:
https://sundials--547.org.readthedocs.build/en/547/arkode/Butcher_link.html#id61

If that looks good, I'll do the same for DIRK and SPRK (MRI already exists). I'll also remove all the corresponding constants from Constants.rst.

@gardner48
Copy link
Member

@gardner48 @drreynolds can you confirm this is the table format you're looking for: https://sundials--547.org.readthedocs.build/en/547/arkode/Butcher_link.html#id61

If that looks good, I'll do the same for DIRK and SPRK (MRI already exists). I'll also remove all the corresponding constants from Constants.rst.

Yes, that's what I was thinking

@Steven-Roberts Steven-Roberts mentioned this pull request Sep 17, 2024
Merged
@balos1 balos1 modified the milestones: SUNDIALS Next, SUNDIALS Next^2 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 requested changes

@drreynolds drreynolds drreynolds left review comments

@balos1 balos1 Awaiting requested review from balos1 balos1 is a code owner

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pkg-ARKODE
Projects
None yet
Milestone
SUNDIALS After Next
Development

Successfully merging this pull request may close these issues.
4 participants
@Steven-Roberts @gardner48 @drreynolds @balos1